Refactor for JuMP v0.21 compatibility #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielolsen
changed the title
BainanXia
approved these changes
Jul 23, 2020
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor to be compatible with the latest version of JuMP (0.21.3), and require this version when installing REISE.jl. The last time we tried updating to JuMP v0.21 by removing the now-deprecated
with_optimizersyntax (see #44), the latest version of JuMP was 0.21.2, which caused an error when used with the previously-compatible syntax for constructing one or more of our constraints. This has been fixed in JuMP v0.21.3 (see jump-dev/JuMP.jl#2235).Closes #55.
What is the code doing
loop.jl: using the JuMP v0.21 syntax to set solver parameters, instead of the JuMP v0.20 syntax (see set_parameter -> set_optimizer_attribute jump-dev/JuMP.jl#2150).Project.toml: specify v0.21.3 (will match any version 0.21.x where x>=3).Manifest.toml: automatically generated file to instantiate all dependencies and sub-dependencies as installed during development/testing.README.md: updating documentation to reflect JuMP changes.Validation
This has been tested successfully using a fresh Julia environment and the input files from Scenario 526.
Time to review
It is four lines of changes.