Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use black profile for isort #107

Merged
merged 1 commit into from
Feb 5, 2021
Merged

ci: use black profile for isort #107

merged 1 commit into from
Feb 5, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Feb 5, 2021

Purpose

We can take advantage of isort's built in "profile" for black compatibility. This includes a line length option which we were msising, along with a couple others I'm not sure about. Source from their repo is easy to read.

What the code is doing

Added isort section in tox.ini

Testing

Ran tox -e format locally, and ci passes.

Time estimate

5 min

@jenhagg jenhagg requested a review from danielolsen February 5, 2021 20:29
@jenhagg jenhagg self-assigned this Feb 5, 2021
@jenhagg jenhagg added this to the Hey Joe milestone Feb 5, 2021
@jenhagg jenhagg merged commit 35ad61a into develop Feb 5, 2021
@jenhagg jenhagg deleted the jon/isort branch February 5, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants