-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More CI - run pytest in github action #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I don't have experience with github actions so I can't comment on the finer details, but overall it's pretty easy to tell what's going on. Everything looks good to me.
I'm so stoked we're getting in more CI. :D
|
||
jobs: | ||
build: | ||
if: "!contains(github.event.head_commit.message, 'skip_ci')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: [3.6, 3.7, 3.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this line work? Does it test on each of these versions of python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that basically creates 3 separate jobs, each with a different value of ${{ matrix.python-version }}
which is up to us to use accordingly, in this case by passing it to relevant steps/commands. Some docs if you're interested.
uses: actions/checkout@v2 | ||
with: | ||
path: PreREISE | ||
- name: Checkout PowerSimData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's possible to include a newline between each step, that would probably make it more readable
Is it going to clone PoweSimData if it is already installed and possibly overwriting it? |
This only runs on github VMs with a fresh environment each time, so PowerSimData will always need to be cloned. |
Sorry, I forgot the PR was about running tests on GitHub. For some reason I had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I really like the skip_ci
feature.
Purpose - automated testing
What it does - Similar setup as powersimdata, but added a couple things:
Time to review - 10 mins, depending on how much the yaml could be improved. You can see it works by clicking on the green checkmarks, but I'm learning the yaml format as I go so I'm sure it can be optimized somehow.