Add pytest to ci and setup pipenv #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Jul 7, 2020
rouille
reviewed
Jul 7, 2020
rouille
approved these changes
Jul 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same things as in PreREISE: Breakthrough-Energy/PreREISE#95
Purpose - run unit tests in CI pipeline, add pipenv as option for installing packages
What it does - add the necessary files for this to work, no package updates here since we used this repo as the baseline for other package versions.
One observation is that in Pipfile.lock, we have scipy at 1.5.1, which is higher than in PowerSimData's requirements, but this is expected since we're using setup.py to install it and version is not pinned there.
Time to review - 5 mins (mostly duplicated, from linked PR, just updated names where applicable)