-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function to create transformers within substations #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c4c0cd
to
2b8cb34
Compare
6716ebb
to
53e2296
Compare
2b8cb34
to
b01ffe1
Compare
With #210 merged, this is now ready for a full review. |
rouille
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 task
danielolsen
added a commit
that referenced
this pull request
Sep 22, 2021
…transformers feat: add function to create transformers within substations
This was referenced Nov 1, 2021
danielolsen
added a commit
that referenced
this pull request
Dec 8, 2021
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Jan 5, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Jan 8, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Jan 31, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Feb 25, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Mar 15, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Apr 1, 2022
…transformers feat: add function to create transformers within substations
danielolsen
added a commit
that referenced
this pull request
Apr 5, 2022
…transformers feat: add function to create transformers within substations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Closes #206.
This is a draft PR right now, since it relies on code from #210. It could also become part of #210.What the code is doing
Using buses, grouped by substation, for each substation with more than one bus, a transformer is added between the highest-voltage bus in the substation and each other bus. This is an arbitrary topology that seems reasonable enough, although it is by no means the best one.
Testing
A new unit test is added which covers the bases of: no transformers within a substation, one transformer within a substation, multiple transformers within a substation.
Usage Example
Time estimate
15 minutes.