-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter DC lines out of AC transmission network processing within HIFLD construction #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
reviewed
Nov 2, 2021
BainanXia
reviewed
Nov 2, 2021
BainanXia
reviewed
Nov 2, 2021
BainanXia
reviewed
Nov 2, 2021
22ef258
to
6ecc3a4
Compare
BainanXia
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Thanks!
540f1f1
to
f416584
Compare
4 tasks
danielolsen
added a commit
that referenced
this pull request
Dec 8, 2021
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Jan 5, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Jan 8, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Jan 31, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Feb 25, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Mar 15, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Apr 1, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
danielolsen
added a commit
that referenced
this pull request
Apr 5, 2022
feat: filter DC lines out of AC transmission network processing within HIFLD construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Partial fulfilment of #233: this addresses the HVDC transmission lines within the HIFLD dataset, but does not yet address the B2Bs, which will require a different method of splitting substations into sub-substations for each interconnection.
What the code is doing
In const.py, ratings are added for DC lines with known capacities.
In transmission.py:
split_lines_to_ac_and_dc
is added to filter out DC lines via some combination of theTYPE
attribute of the HIFLD dataset and manually specified indices.build_transmission
uses this function, then adds impedances and AC ratings to AC branches only (using functionality introduced in feat: add function to create transformers within substations #218 and feat: add functions to estimate branch parameters (impedance and rating) #219), and uses the pre-defined ratings from const.py to add capacities to the DC lines.Testing
Tested manually.
Usage Example/Visuals
Branch entries get impedance (
x
) and rating, DC lines getPmax
andPmin
.Time estimate
15 minutes.