Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #620 #746

Merged
merged 1 commit into from
Oct 5, 2022
Merged

resolves #620 #746

merged 1 commit into from
Oct 5, 2022

Conversation

jamesros161
Copy link
Contributor

@jamesros161 jamesros161 commented Oct 4, 2022 •
edited
Loading

This PR resolves #620

Testing Instructions

  1. Install Crio using the test zip provided below
    crio-2.17.1-rc.zip
  2. Install Sprout Invoices.
  3. Setup an invoice.
  4. View the invoice.
  5. Click on 'Customize' in the admin bar at the top of the window while viewing the invoice.
  6. Click on the 'Sprout Invoices' panel.
  7. Customize the various options for the invoice and publish.
  8. Ensure that the changes saved.
  9. Repeat Steps 3-8 but using a different Sprout Invoices template for the Invoices. ( WP Dashboard > Sprout Invoices > General Settings > Invoices > Invoice Template )
  10. Repeat Steps 3 - 8 but using an Estimate instead of an Invoice

elanasparkle
elanasparkle approved these changes Oct 4, 2022
View reviewed changes
Copy link

@elanasparkle elanasparkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Sprout Invoices and invoices and estimates display properly and allow you to switch between the themes.

@jamesros161 jamesros161 mentioned this pull request Oct 4, 2022
Closed
@jamesros161 jamesros161 merged commit 0f2514a into branch-2.17.1 Oct 5, 2022
@jamesros161 jamesros161 mentioned this pull request Oct 5, 2022
Merged
jamesros161 added a commit that referenced this pull request Oct 5, 2022
@jamesros161
Branch 2.17.1 (#747)
fe7dd11 
* update version numbers

* resolves #620 (#746)

* resolves #721 (#745)

* Issues 738 & 733 (#740)

* resolves #738

* Resolves #733

* update Buttons in yarn.lock

* generalize btn selectors

* update Buttons in yarn.lock

* update readme

* update readme
@jamesros161 jamesros161 deleted the issue-620 branch February 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elanasparkle elanasparkle elanasparkle approved these changes

@avonville avonville avonville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesros161 @elanasparkle @avonville