Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 738 & 733 #740

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Issues 738 & 733 #740

merged 5 commits into from
Oct 5, 2022

Conversation

jamesros161
Copy link
Contributor

@jamesros161 jamesros161 commented Sep 30, 2022

Resolves #738
Resolves #733

Testing Instructions

Install the attached Crio Zip File.
crio-2.17.1-rc2.zip

Testing Issue #738

  1. Create a post with two buttons, with one button having the .button-primary class and the other having the .button-secondary class. ( Alternatively, install the Crio Starter content, and you can use the section of the home page that already has two buttons side by side to test.
  2. In the WordPress Customizer, customize both the primary buttons and the secondary buttons setting both to size 4 ( btn-large ).
  3. Ensure that both the Button Primary and the Button Secondary buttons are the same size, line up properly, and that the font behaves the same.
  4. Add the .btn and .button-primary class to a menu item, and ensure that the button behaves itself.
  5. Change the menu item classes to use .button-secondary and make sure that it still behaves itself.
  6. Create a button that does not utilize either the .button-primary or .button-secondary classes by using the PPB Button Component, and ensure that the buttons still behave as expected.

Testing Issue #733

  1. Setup the footer for your site to utilize the Customizer Footer, with at least one widget area.
  2. In that widget area, add a 'Custom HTML' widget, with the following markup:
<a class="btn button-primary">Button Primary</a>
<a class="btn button-secondary">Button Secondary</a>
  1. Ensure that the Buttons' styling in the footer matches that of the buttons in the site content ( background, border, text, and hover effects ).

@nicolepaschen
Copy link
Member

nicolepaschen commented Sep 30, 2022

button-text

The text does not seem centered in the button until I undo the height (see gif)
I had a thick border on the button

@nicolepaschen
Copy link
Member

alignment is off in the editor now:
image

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 3, 2022

Buttons in the footer do not look correct either they look like how they look in the editor (live preview and font end look the same):
image

@nicolepaschen
Copy link
Member

nicolepaschen commented Oct 4, 2022

custom footer menu buttons look super wonky until I save, then still not correct. front end is correct tho. also the menu buttons have a hover effect they should not have in the editor.
footer-menu-buttons

@jamesros161 jamesros161 requested a review from avonville October 4, 2022 14:37
@jamesros161 jamesros161 merged commit d026915 into branch-2.17.1 Oct 5, 2022
@jamesros161 jamesros161 mentioned this pull request Oct 5, 2022
jamesros161 added a commit that referenced this pull request Oct 5, 2022
* update version numbers

* resolves #620 (#746)

* resolves #721 (#745)

* Issues 738 & 733 (#740)

* resolves #738

* Resolves #733

* update Buttons in yarn.lock

* generalize btn selectors

* update Buttons in yarn.lock

* update readme

* update readme
@jamesros161 jamesros161 deleted the issue-738 branch February 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants