Support CMake v3.20+; fix for nmodl-as-a-submodule #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CMake v3.20+ then the NVHPC compilers are identified as NVHPC, not PGI. Also make sure that NMODL sources its own CompilerHelper.cmake, previously in the case that NMODL is built as a submodule of CoreNEURON and CoreNEURON is built as a submodule of NEURON then NMODL would source the CompilerHelper.cmake from NEURON.
iomaganaris
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CMake v3.20+ then the NVHPC compilers are identified as NVHPC, not PGI (see also: neuronsimulator/nrn#1266 and BlueBrain/CoreNeuron#543).
Also make sure that NMODL sources its own
CompilerHelper.cmake, previously in the case that NMODL is built as a submodule of CoreNEURON and CoreNEURON is built as a submodule of NEURON then NMODL would source theCompilerHelper.cmakefrom NEURON.