This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
CMake v3.20+ no longer labels NVHPC as PGI. #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
approved these changes
May 10, 2021
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CoreNEURON CMake has some special handling for PGI/NVHPC compilers. In older CMake versions these were all labelled as "PGI", but in CMake v3.20+ then the NVHPC compilers have their own identifier.
How to test this?
Build with CMake v3.20+, an NVHPC compiler and GPU support. The build will fail without this change.
Test System
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=master,