Add support for match_phrase_prefix in SQL and PPL #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Change generateQueries signature to use more appropriate Map type. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
…quired Add match_phrase_prefix to SQL with required parameters.
Private constants look odd. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
A convenience method to simplify writing tests. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
…l-opt match_phrase_prefix in SQL with optional parameters
…refix-#186 # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java # core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/filter/FilterQueryBuilder.java # opensearch/src/test/java/org/opensearch/sql/opensearch/storage/script/filter/FilterQueryBuilderTest.java # sql/src/main/antlr/OpenSearchSQLLexer.g4 # sql/src/main/antlr/OpenSearchSQLParser.g4
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
…l-req Add match_phrase_prefix support to where command in PPL
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
…l-itests Add integration tests for match_phrase_prefix in SQL
- match_phrase was used in a couple places. - some optional parameters were missing. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
match_phrase_prefix documentation for SQL and PPL
…l_it Integration tests for match_phrase_prefix in PPL
Codecov Report
@@ Coverage Diff @@
## integ-match_phrase_prefix-#186 #79 +/- ##
=================================================================
Coverage 97.71% 97.71%
- Complexity 2801 2810 +9
=================================================================
Files 270 271 +1
Lines 6912 6929 +17
Branches 439 439
=================================================================
+ Hits 6754 6771 +17
Misses 157 157
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…refix-#186 # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # docs/user/dql/functions.rst # docs/user/ppl/functions/relevance.rst
core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MaxKsyunz <[email protected]>
Yury-Fridlyand
approved these changes
Jun 25, 2022
acarbonetto
requested changes
Jun 27, 2022
...a/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/MatchPhraseQuery.java
Show resolved
Hide resolved
Signed-off-by: MaxKsyunz <[email protected]>
Yury-Fridlyand
approved these changes
Jun 28, 2022
5 tasks
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
Include whether to add z coords into Geometry or not as param to random function, except Polygon. Generating true random polygon is very complicated since 3 points at least to be non-collinear. Will add support to be truly random during later commit. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for match_phrase_prefix in SQL and PPL
Issues Resolved
#186
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.