Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_phrase_prefix in SQL with optional parameters #70

Merged

Conversation

MaxKsyunz
Copy link

Description

Support boost, slop, analyzer, zero_terms_query, and max_expansions optional parameters for match_phrase_prefix in SQL.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MaxKsyunz MaxKsyunz requested a review from a team June 9, 2022 08:29
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #70 (f68eb9e) into dev-match_phrase_prefix-#186 (f9c90a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##             dev-match_phrase_prefix-#186      #70   +/-   ##
===============================================================
  Coverage                           97.66%   97.67%           
- Complexity                           2747     2752    +5     
===============================================================
  Files                                 269      269           
  Lines                                6781     6789    +8     
  Branches                              435      435           
===============================================================
+ Hits                                 6623     6631    +8     
  Misses                                157      157           
  Partials                                1        1           
Flag Coverage Δ
sql-engine 97.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...ilter/lucene/relevance/MatchPhrasePrefixQuery.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/MatchPhraseQuery.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c90a3...f68eb9e. Read the comment docs.

Signed-off-by: MaxKsyunz <[email protected]>
@MaxKsyunz MaxKsyunz merged commit b4177a6 into dev-match_phrase_prefix-#186 Jun 10, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-match_phrase_prefix-#186-sql-opt branch June 13, 2022 15:35
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
Added new content type "xy_shape" to index document with
field of type "xy_shape". This is similar to geo_shape. It accepts
value as either GeoJSON format or WKT format.
This has same parameters as geo_shape like ignore_malformed,
ignore_z_value, coerce, orientation.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants