Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-ux): aligned X and Close buttons in Transaction error modal #654

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix(ui-ux): aligned X and Close buttons in Transaction error modal #654

merged 2 commits into from
Mar 6, 2023

Conversation

fullstackninja864
Copy link
Contributor

@fullstackninja864 fullstackninja864 commented Mar 6, 2023 •
edited
Loading

What this PR does / why we need it:

This PR contain

  1. Aligned X and Close buttons in Transaction error modal
  2. Minor UI fixes

Which issue(s) does this PR fixes?:

Fixes #608

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors on web
  • Tested on Light mode and Dark mode*
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*
  • Added translations*

@netlify
Copy link

netlify bot commented Mar 6, 2023 •
edited
Loading

✅ Deploy Preview for quantumbridge ready!

Name Link
🔨 Latest commit e81295c
🔍 Latest deploy log https://app.netlify.com/sites/quantumbridge/deploys/64057f3ce8bef10008e8bb9a
😎 Deploy Preview https://deploy-preview-654--quantumbridge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the kind/fix Fix a bug label Mar 6, 2023
@fullstackninja864 fullstackninja864 self-assigned this Mar 6, 2023
@lykalabrada lykalabrada merged commit c71f06d into main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lykalabrada lykalabrada lykalabrada approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@kyleleow kyleleow Awaiting requested review from kyleleow

@greggtan greggtan Awaiting requested review from greggtan

@pierregee pierregee Awaiting requested review from pierregee

Assignees
No one assigned
Labels
kind/fix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM-DFI: Not aligned X and Close buttons in Transaction error modal
2 participants
@fullstackninja864 @lykalabrada