Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-DFI: Not aligned X and Close buttons in Transaction error modal #608

Closed
mikhail-zlochevskyi opened this issue Mar 1, 2023 · 5 comments · Fixed by #654
Closed

EVM-DFI: Not aligned X and Close buttons in Transaction error modal #608

mikhail-zlochevskyi opened this issue Mar 1, 2023 · 5 comments · Fixed by #654
Labels
bug/minor Minor issue which is non-breaking and has a workaround kind/bug Something isn't working needs/area Needs area label(s) needs/priority Needs a priority label needs/triage Waiting for triage to be accepted Post-Launch stale No activity for a significant amount of days

Comments

@mikhail-zlochevskyi
Copy link
Contributor

What happened:

  1. When you press X -- you see the confirmation message "Are you sure you want to leave your transaction?"
  2. When you press Close -- you redirects to the main screen.

What you expected to happen:

  1. When you press X -- you see the confirmation message "Are you sure you want to leave your transaction?"
  2. When you press Close -- you see the confirmation message "Are you sure you want to leave your transaction?"

How to reproduce it (as minimally and precisely as possible):

image

2.

image

Anything else we need to know?:

@mikhail-zlochevskyi mikhail-zlochevskyi added bug/minor Minor issue which is non-breaking and has a workaround kind/bug Something isn't working labels Mar 1, 2023
@github-actions github-actions bot added the needs/triage Waiting for triage to be accepted label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

@mikhail-zlochevskyi: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the WavesHQ developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added the needs/area Needs area label(s) label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

@mikhail-zlochevskyi: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the WavesHQ developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added the needs/priority Needs a priority label label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

@mikhail-zlochevskyi: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details

I am a bot created to help the WavesHQ developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

This issue is stale because it has been open for 40 days without any activity. Please remove the stale label or this will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for a significant amount of days label Apr 15, 2023
@mikhail-zlochevskyi
Copy link
Contributor Author

issue was fixed, verified at 1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/minor Minor issue which is non-breaking and has a workaround kind/bug Something isn't working needs/area Needs area label(s) needs/priority Needs a priority label needs/triage Waiting for triage to be accepted Post-Launch stale No activity for a significant amount of days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants