-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off console logging by default #261
Turn off console logging by default #261
Conversation
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Turns off the console logging by default. More critical for console apps as the versioning is now called directly, leading to an bombardment of versioning logging drastically slowing the upgrader down. When ProcessingLoop is called, the logging is turned on, as this is only done when the versioning is run as a standalone .exe with its own log, and not affecting the main log of any application.
@IsakNaslundBh to confirm, the following actions are now queued:
|
Changing behaviour, switching to false from the BHoM_ENgine instead
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense and reflect my previous comments. Happy to approve 👍
@IsakNaslundBh just to let you know, I have provided a |
Issues addressed by this PR
Closes #260
Turns off the console logging by default. More critical for console apps as the versioning is now called directly, leading to an bombardment of versioning logging drastically slowing the upgrader down. When ProcessingLoop is called, the logging is turned on, as this is only done when the versioning is run as a standalone .exe with its own log, and not affecting the main log of any application.
Test files
Changelog
Additional comments