Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off console logging by default #261

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #260

Turns off the console logging by default. More critical for console apps as the versioning is now called directly, leading to an bombardment of versioning logging drastically slowing the upgrader down. When ProcessingLoop is called, the logging is turned on, as this is only done when the versioning is run as a standalone .exe with its own log, and not affecting the main log of any application.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Apr 26, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 26, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Apr 26, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

Turns off the console logging by default. More critical for console apps as the versioning is now called directly, leading to an bombardment of versioning logging drastically slowing the upgrader down.
When ProcessingLoop is called, the logging is turned on, as this is only done when the versioning is run as a standalone .exe with its own log, and not affecting the main log of any application.
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Apr 26, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check installer
  • check core
  • check copyright-compliance

BHoMUpgrader/Upgrader.cs Outdated Show resolved Hide resolved
BHoMUpgrader/Upgrader.cs Outdated Show resolved Hide resolved
BHoMUpgrader/Upgrader.cs Outdated Show resolved Hide resolved
BHoMUpgrader/Upgrader.cs Outdated Show resolved Hide resolved
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check core
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check core
  • check copyright-compliance

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense and reflect my previous comments. Happy to approve 👍

Copy link

bhombot-ci bot commented May 6, 2024

@IsakNaslundBh just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh IsakNaslundBh merged commit 9ef313a into develop May 6, 2024
5 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Versioning_Toolkit-#260-TurnOfConsoleLoggingByDefault branch May 6, 2024 08:27
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn of console logging by default
2 participants