Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn of console logging by default #260

Closed
IsakNaslundBh opened this issue Apr 24, 2024 · 0 comments · Fixed by #261
Closed

Turn of console logging by default #260

IsakNaslundBh opened this issue Apr 24, 2024 · 0 comments · Fixed by #261
Assignees
Labels
type:feature New capability or enhancement

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

After the changes made in BHoM/BHoM_Engine#3332 where the upgrader is called directly than via pipes, all console information written out by the upgrader is being lo9gged on the main process pipe instead.

Suggesting adding a "WriteToLog" property to the upgrader, defaulting to false, that is being checked each time before writing to log. Especially critical for console apps, as with the current situation, there is an bombardment of upgrader information being written to the log.
@FraserGreenroyd @adecler happy for any comments if you disagree with this approach.

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Apr 24, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant