Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning added for RevitIdentifiers #141

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Versioning added for RevitIdentifiers #141

merged 1 commit into from
Feb 25, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 24, 2021 •
edited
Loading

Issues addressed by this PR

Closes nothing 🙈

Test files

See BHoM/Revit_Toolkit#977.

Changelog

  • versioning added for RevitIdentifiers

Additional comments

@pawelbaran pawelbaran added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 24, 2021
@pawelbaran pawelbaran self-assigned this Feb 24, 2021
@pawelbaran pawelbaran mentioned this pull request Feb 24, 2021
Merged
LMarkowski
LMarkowski approved these changes Feb 25, 2021
View reviewed changes
Copy link

@LMarkowski LMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving simultaneously with RVT_TK PR.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-installer task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-core task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@FraserGreenroyd to confirm, check-core task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-installer task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@FraserGreenroyd FraserGreenroyd merged commit 3b9bcc7 into master Feb 25, 2021
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#973-AddNewRevitIdentifiers branch February 25, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMarkowski LMarkowski LMarkowski approved these changes

Assignees

@pawelbaran pawelbaran

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelbaran @FraserGreenroyd @LMarkowski