-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Revit identifiers added #977
Conversation
@BHoMBot check compliance |
@pawelbaran to confirm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and I didn't manage to break anything in the test file. Approving.
/azp run Revit_Toolkit.CheckInstaller |
@BHoMBot check installer |
@pawelbaran to confirm, |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Revit_Toolkit.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
@pawelbaran just to let you know, I have provided a |
1 similar comment
@pawelbaran just to let you know, I have provided a |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued. |
@BHoMBot check core |
@pawelbaran to confirm, |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued. |
NOTE: Depends on
Not direct dependency, but versioning needs to be run on BHoM/Versioning_Toolkit#141.
Issues addressed by this PR
Closes #945
Closes #963
Closes #973
Test files
On SharePoint - please note that full functionality requires rebuilding Versioning_Toolkit on BHoM/Versioning_Toolkit#141.
Changelog
Workset
,HostId
andLinkPath
properties added toRevitIdentifiers
fragmentQuery
methods extracting the above information from aBHoMObject
addedAdditional comments