Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Revit identifiers added #977

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 24, 2021

NOTE: Depends on

Not direct dependency, but versioning needs to be run on BHoM/Versioning_Toolkit#141.

Issues addressed by this PR

Closes #945
Closes #963
Closes #973

Test files

On SharePoint - please note that full functionality requires rebuilding Versioning_Toolkit on BHoM/Versioning_Toolkit#141.

Changelog

  • Workset, HostId and LinkPath properties added to RevitIdentifiers fragment
  • Query methods extracting the above information from a BHoMObject added

Additional comments

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 24, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

Copy link
Contributor

@LMarkowski LMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I didn't manage to break anything in the test file. Approving.

@pawelbaran
Copy link
Member Author

/azp run Revit_Toolkit.CheckInstaller

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-installer task is now queued.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pawelbaran
Copy link
Member Author

/azp run Revit_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Versioning_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Versioning_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-core task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, the task for checking if this Pull Request is ready to merge is now queued.

@pawelbaran pawelbaran merged commit b76209c into master Feb 25, 2021
@pawelbaran pawelbaran deleted the Revit_Toolkit-#973-AddNewRevitIdentifiers branch February 25, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
2 participants