Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds authenticator to Speckle_Toolkit; enables Excel workflow #91

Closed
wants to merge 30 commits into from

Conversation

alelom
Copy link
Member

@alelom alelom commented May 26, 2020

NOTE: Depends on

BHoM/BHoM_UI#271
BHoM/BHoM_Engine#1807

Issues addressed by this PR

Closes #90
Closes #92
Closes #93

This enables the following workflow:
ExcelSpeckle

which effectively makes for a free 3Dviewer shipping with BHoM - independent from any CAD software.

In order to enable this workflow, I had to set Copy-Local to true for:

  • SpeckleCore
  • SpeckleCoreGeometryClasses

This means I had to add a "selective xcopy" in the PostBuild events that does the copy or not only if Speckle is installed on your machine.

Test files

In the repository:
GitHub\Speckle_Toolkit\Test Scripts\#90-Auth

  • Excel: SpeckleAuthTest.xlsx – works fine as above.

  • Grasshopper: auth.gh – as said above, you need to either uninstall your speckle or set Copy-Locals to False and make sure to recompile BHoM_UI after cleaning %APPDATA%/BHoM.

Changelog

  • Adds Authorisation method that opens a Popup where you can log in in Speckle.
  • Enables Excel workflow in Speckle
  • The SpeckleCore.dll and SpeckleCoreGeometry.dll are copied to the BHoM installation folder only if Speckle is not installed.

Additional comments

@alelom alelom added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label May 26, 2020
@alelom alelom requested review from al-fisher and rwemay May 26, 2020 17:28
@alelom alelom requested review from kThorsager and removed request for kThorsager May 26, 2020 17:29
@alelom alelom marked this pull request as draft May 26, 2020 17:30
@rwemay
Copy link
Member

rwemay commented May 27, 2020

Looking great! Give me a shout on Teams/email about the excel test script. Keen that we Template these as much as possible to consolidate samples/UX.

@alelom alelom removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jun 5, 2020
@alelom alelom marked this pull request as ready for review June 5, 2020 13:05
@alelom
Copy link
Member Author

alelom commented Jan 6, 2021

Closed it for now. This was a prototype that needs more work, especially in light of the recent Speckle 2.0 update.

@alelom alelom closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants