Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BHoM_UI: Add support for "&" ByRef types in Caller #271

Merged
merged 1 commit into from
Jun 2, 2020
Merged

BHoM_UI: Add support for "&" ByRef types in Caller #271

merged 1 commit into from
Jun 2, 2020

Conversation

alelom
Copy link
Member

@alelom alelom commented May 26, 2020

Issues addressed by this PR

Closes #270

Test files

Changelog

Additional comments

@alelom alelom requested review from ajc-burohappold, al-fisher, adecler and epignatelli and removed request for ajc-burohappold May 26, 2020 17:19
@alelom alelom self-assigned this May 26, 2020
@alelom alelom mentioned this pull request May 26, 2020
Closed
@adecler
Copy link
Member

adecler commented Jun 2, 2020

I don't see a problem with the code itself although I haven't tested it myself.
I would just flag up that this probably means we only have partial support for ByRef types within the UI. Since partial support tends to create confusing problems, I would recommend raising a separate issue as a minimum if this is too much work to take care of here.

This was referenced Jun 2, 2020
Closed
Closed
adecler
adecler approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge as long as ByRef types are provided full support across the framework.
See separate issues raised:

@adecler
Copy link
Member

adecler commented Jun 2, 2020

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rwemay rwemay merged commit 996464f into master Jun 2, 2020
@rwemay rwemay deleted the #90-Authentication branch June 2, 2020 09:34
@BingWangUS
Copy link

This is a great improvement for searching. Cannot have "space" is kind of a paint before this.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

@epignatelli epignatelli Awaiting requested review from epignatelli

Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for "&" ByRef types in Caller
5 participants
@alelom @adecler @BingWangUS @rwemay @FraserGreenroyd