Assemblies and namespaces reorganised #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
requested review from
al-fisher,
FraserGreenroyd,
AndreBalasian and
kThorsager
|
/azp run Revit_Toolkit.CheckCore |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Revit_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndreBalasian
approved these changes
May 29, 2020
AndreBalasian
previously approved these changes
May 29, 2020
pawelbaran
changed the title
|
/azp run Revit_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndreBalasian
approved these changes
Jun 1, 2020
kThorsager
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #517
Test files
Standard macro tests on SharePoint - everything should work as before.
IMPORTANT: Since this PR changes folder and assembly names, it is recommended to clean the Revit_Toolkit GitHub folder as well as clean the BHoM/Assemblies before testing.
Changelog
BH.Revit.Adapter.CoreBH.Revit.Engine.CoreSetTagsandSetIdentifiersmethods were centralized inside Revit_Core_Engine, unused messages have been removedRevitUIAdapterhas been renamed toRevitListenerAdapterBH.oM.Adapters.Revit.Interfacenamespace has been eliminated with all interfaces being moved across to their relevant subnamespacesAdditional comments
Although the PR is massive, it should not change the mechanics of the code by any means. Thanks to the fact that most of the code base is not exposed by any of the UIs, almost no versioning was needed.
@FraserGreenroyd due to the change in assembly structure, I would expect following issues;
Happy to assist with resolving these 🤖