Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revit_Toolkit: pull of BEnv elements results in duplicate elements #739

Closed
pawelbaran opened this issue May 29, 2020 · 0 comments · Fixed by #741
Closed

Revit_Toolkit: pull of BEnv elements results in duplicate elements #739

pawelbaran opened this issue May 29, 2020 · 0 comments · Fixed by #741
Assignees
@pawelbaran
Labels
type:bug Error or unexpected behaviour
Milestone
BHoM 3.2 β MVP

Comments

@pawelbaran
Copy link
Member

pawelbaran commented May 29, 2020 •
edited
Loading

Description:

When pulling BEnv elements, they sometimes get duplicated because they get pulled from both physical and analytical model.

@FraserGreenroyd @rboulton-BH FYI I have a fix for it ready to PR once #737 is closed.

Test file(s):

Model and script.
@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label May 29, 2020
@pawelbaran pawelbaran added this to the BHoM 3.2 β MVP milestone May 29, 2020
@pawelbaran pawelbaran self-assigned this May 29, 2020
pawelbaran added a commit that referenced this issue May 29, 2020
@pawelbaran
#739 fix
b9b2a04
pawelbaran added a commit that referenced this issue Jun 1, 2020
@pawelbaran
Merge branch 'Revit_Toolkit#517-RenamingAssemblies' into ForReference…
01a86e0 
…-Revit_Toolkit-#739-DuplicateBEnvPull
pawelbaran added a commit that referenced this issue Jun 1, 2020
@pawelbaran
#739 fix
9005339
@pawelbaran pawelbaran mentioned this issue Jun 1, 2020
Merged
pawelbaran added a commit that referenced this issue Jun 3, 2020
@pawelbaran
#739 fix
1403086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging a pull request may close this issue.

Pull of BEnv elements stopped from returning duplicate elements BHoM/Revit_Toolkit
1 participant
@pawelbaran