Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure availability of base Python environment #74

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Feb 11, 2022

Issues addressed by this PR

Closes #73
Closes #72

Enables creation of requirements.txt file, rather than relying on one for environment creation, and moves definition of the environment into a toolkit-specific *_Toolkit.json for placement in %ProgramData%\BHoM\Settings\Python. Checks to see whether the base Python environment is available for future dependence on core decorators referenced by downstream methods.

Test files

BHoM_Test.zip

Changelog

Additional comments

Removed auto-imported "using" in header
@tg359
Copy link
Contributor Author

tg359 commented Feb 11, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 20 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Feb 16, 2022

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@BHoM BHoM deleted a comment from bhombot-ci bot Feb 16, 2022
@BHoM BHoM deleted a comment from bhombot-ci bot Feb 16, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 5214476667

@FraserGreenroyd
Copy link
Contributor

@BHoMBot fix project file ref. 5214476667

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 18, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • versioning

There are 26 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Feb 21, 2022

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • serialisation

There are 35 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • serialisation

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run through with @tg359 and this is good to go to alpha for further testing.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Feb 21, 2022
@FraserGreenroyd FraserGreenroyd merged commit d202372 into main Feb 21, 2022
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#73-EnsureBaseEnvironmentAvailable branch February 21, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants