Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure availability of base Python environment #39

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Feb 11, 2022

NOTE: Depends on

BHoM/Python_Toolkit#74

Issues addressed by this PR

Closes #29

Checks to see whether the base Python environment is available for future dependence on core decorators referenced by downstream methods.

Also includes some updates to task-critical results handling.

Test files

BHoM_Test.zip

Changelog

Additional comments

@tg359 tg359 added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 11, 2022
@tg359 tg359 self-assigned this Feb 11, 2022
@tg359 tg359 changed the title Python toolkit #73 ensure base environment available Ensure availability of base Python environment Feb 11, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on Python_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @tg359 on Python_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 10 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 18, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 18, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@tg359 just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Python_Toolkit

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Feb 21, 2022

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • serialisation

There are 29 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 21, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • serialisation

There are 4 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run through with @tg359 and this is good to go to alpha for further testing.

@FraserGreenroyd FraserGreenroyd merged commit f77c86a into main Feb 21, 2022
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#73-EnsureBaseEnvironmentAvailable branch February 21, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LadybugTools_Toolkit: Changes in upstream Python_Toolkit
2 participants