Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo_Toolkit: Updated namespaces to Adapters #120

Closed
wants to merge 6 commits into from

Conversation

alelom
Copy link
Member

@alelom alelom commented Aug 14, 2020

Issues addressed by this PR

Closes #119

@adecler @IsakNaslundBh as I am not sure of the Toolkits dependant on this.
Could you please help me out in tracking any dependant that will be affected by this?

Test files

Just check any existing test file.

Changelog

Additional comments

@alelom alelom requested a review from adecler August 14, 2020 11:14
@alelom alelom self-assigned this Aug 14, 2020
@alelom alelom added the type:compliance Non-conforming to code guidelines label Aug 14, 2020
@alelom alelom changed the title Mongo_oM: Updated namespaces Mongo_Toolkit: Updated namespaces to Adapters Aug 14, 2020
@alelom alelom requested a review from IsakNaslundBh August 14, 2020 11:58
@alelom
Copy link
Member Author

alelom commented Aug 14, 2020

/azp run Mongo_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler
Copy link
Member

adecler commented Aug 15, 2020

From the top of my head:

  • DataViz_Toolkit
  • BHoMAnalytics_Toolkit

Wee need a method in the reflection engine that gives us that info (we had it with the wheel)

@alelom
Copy link
Member Author

alelom commented Aug 17, 2020

From the top of my head:

  • DataViz_Toolkit
  • BHoMAnalytics_Toolkit

Wee need a method in the reflection engine that gives us that info (we had it with the wheel)

Could you take care of these @adecler ?

@alelom alelom removed their assignment Aug 27, 2020
@adecler
Copy link
Member

adecler commented Nov 11, 2020

This is now superseded by #125
@alelom , can you confirm ?

@alelom
Copy link
Member Author

alelom commented Nov 11, 2020

This is now superseded by #125
@alelom , can you confirm ?

Confirmed, closing.

@alelom alelom closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongo_Toolkit: Namespace update to Adapters
2 participants