-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to changes of Namespace Renaming #3
Comments
@alelom , I will not have time to take care of this for you. |
Hey @adecler, no worries, you can do it next sprint too. I had to resort in postponing the deadline yet again as everyone is always busy. For now, I'm short on time too, and I've done basically 70% of the other renamings myself, as this keeps on falling on me. I'll reassign you as this is connected to BHoM/Mongo_Toolkit#120 which I also prefer if you could make sure is correctly aligned to this. |
Sure, no problem. I'll get both done beginning of next milestone. |
There is currently no change needed on this toolkit regarding the namespace. The reason for it is that the Engine methods and oM classes in that repo are local tools not related to the adapter so it doesn't make sense to have them under the adapter namespace. |
Broken rules:
Following confirmation here the namespace in this toolkit, for all items except the adapter should have the namespace
BH.oM.Adapters.ToolkitName
orBH.Engine.Adapters.ToolkitName
instead ofBH.oM.ToolkitName
, etc.The Adapter namespace should remain at
BH.Adapter.ToolkitName
instead ofBH.Adapter.External.ToolkitName
.➡️ Also This should also align with the changes in dependencies: BHoM/Mongo_Toolkit#120
ALSO make sure that the default namespace is set correctly in the oM and Engine Project properties.
➡️ Right click on the project, navigate to the Application tab, and check the default namespace.
Suggestions to restore compliance:
As above.
The text was updated successfully, but these errors were encountered: