Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to changes of Namespace Renaming #3

Closed
alelom opened this issue Aug 27, 2020 · 4 comments
Closed

Align to changes of Namespace Renaming #3

alelom opened this issue Aug 27, 2020 · 4 comments
Assignees
Labels
type:compliance Non-conforming to code guidelines

Comments

@alelom
Copy link
Member

alelom commented Aug 27, 2020

Broken rules:

Following confirmation here the namespace in this toolkit, for all items except the adapter should have the namespace BH.oM.Adapters.ToolkitName or BH.Engine.Adapters.ToolkitName instead of BH.oM.ToolkitName, etc.

The Adapter namespace should remain at BH.Adapter.ToolkitName instead of BH.Adapter.External.ToolkitName.

➡️ Also This should also align with the changes in dependencies: BHoM/Mongo_Toolkit#120

ALSO make sure that the default namespace is set correctly in the oM and Engine Project properties.
➡️ Right click on the project, navigate to the Application tab, and check the default namespace.

Suggestions to restore compliance:

As above.

@alelom alelom added the type:compliance Non-conforming to code guidelines label Aug 27, 2020
@adecler
Copy link
Member

adecler commented Aug 27, 2020

@alelom , I will not have time to take care of this for you.
Can you do this yourself or assigned to someone else, as it is a pretty straightforward task?
Happy to review when done.

@adecler adecler assigned alelom and unassigned adecler Aug 27, 2020
@alelom
Copy link
Member Author

alelom commented Aug 27, 2020

@alelom , I will not have time to take care of this for you.
Can you do this yourself or assigned to someone else, as it is a pretty straightforward task?
Happy to review when done.

Hey @adecler, no worries, you can do it next sprint too. I had to resort in postponing the deadline yet again as everyone is always busy. For now, I'm short on time too, and I've done basically 70% of the other renamings myself, as this keeps on falling on me. I'll reassign you as this is connected to BHoM/Mongo_Toolkit#120 which I also prefer if you could make sure is correctly aligned to this.

@alelom alelom assigned adecler and unassigned alelom Aug 27, 2020
@adecler
Copy link
Member

adecler commented Aug 28, 2020

Sure, no problem. I'll get both done beginning of next milestone.

@adecler
Copy link
Member

adecler commented Oct 13, 2020

There is currently no change needed on this toolkit regarding the namespace. The reason for it is that the Engine methods and oM classes in that repo are local tools not related to the adapter so it doesn't make sense to have them under the adapter namespace.

@adecler adecler closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

No branches or pull requests

2 participants