Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter Serialisation: DataType now serialises properly #149

Merged
merged 6 commits into from
Nov 27, 2023

Apply suggestions from code review

e5ac64a
Select commit
Loading
Failed to load commit list.
Merged

Adapter Serialisation: DataType now serialises properly #149

Apply suggestions from code review
e5ac64a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
BHoMBot-CI / code-compliance succeeded Nov 27, 2023 in 6s

Check Code Compliance

This check has some warnings

Details

There were some warnings found with the code changed in this Pull Request

Annotations

Check warning on line 107 in LadybugTools_Adapter/Convert/ToBHoM.cs

See this annotation in the file changed.

@bhombot-ci bhombot-ci / code-compliance

LadybugTools_Adapter/Convert/ToBHoM.cs#L48-L107 

The use of CustomData within the code is discouraged except in circumstances where volatile data is being used. - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/IsUsingCustomData

Check warning on line 65 in LadybugTools_Adapter/Convert/ToBHoM.cs

See this annotation in the file changed.

@bhombot-ci bhombot-ci / code-compliance

LadybugTools_Adapter/Convert/ToBHoM.cs#L51-L65 

The use of CustomData within the code is discouraged except in circumstances where volatile data is being used. - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/IsUsingCustomData
View more details on BHoMBot-CI