-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter Serialisation: DataType now serialises properly #149
Adapter Serialisation: DataType now serialises properly #149
Conversation
This reverts commit 0c2acb7.
…o removed unnecessary attribute on EPW, as it is reflected in an HCC.
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
Co-authored-by: Fraser Greenroyd <[email protected]>
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
The check |
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @Tom-Kingstone
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #146
Serialised objects of
"DataType"
and"GenericDataType"
are now differentiated by the serialiser, so will now no longer return the error:Objects of type DataType are not yet supported for conversion to a LadybugTools object.
Also forced the json to be an array if it was not already.
Test files
Changelog
Additional comments