Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable adapter workflows with varying "datatype" types #146

Closed
tg359 opened this issue Nov 27, 2023 · 1 comment · Fixed by #149
Closed

Enable adapter workflows with varying "datatype" types #146

tg359 opened this issue Nov 27, 2023 · 1 comment · Fixed by #149
Assignees
@Tom-Kingstone
Labels
type:bug Error or unexpected behaviour

Comments

@tg359
Copy link
Contributor

tg359 commented Nov 27, 2023

Description:

DataType objects can be dynamic with fields varying based on what "type" it represents (yay Python). For C# this gets tricky, but by having a GenericDataType and a DataType we should be able to handle both forms.
@tg359 tg359 added the type:feature New capability or enhancement label Nov 27, 2023
@Tom-Kingstone
Copy link
Contributor

We can actually handle both forms in the current DataType object already defined. This just means slightly changing the serialiser to reflect the different types (as the python side objects have lots of redundancy).

@Tom-Kingstone Tom-Kingstone added type:bug Error or unexpected behaviour and removed type:feature New capability or enhancement labels Nov 27, 2023
@Tom-Kingstone Tom-Kingstone mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapter Serialisation: DataType now serialises properly BHoM/LadybugTools_Toolkit
2 participants
@tg359 @Tom-Kingstone