Log file id and file path #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
rolyhudson,
al-fisher,
FraserGreenroyd and
IsakNaslundBh
This was referenced Feb 16, 2021
|
@BHoMBot check copyright |
|
@adecler to confirm, |
|
@BHoMBot check installer |
al-fisher
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
This is working capturing in log file as expected
As per comment here: https://github.com/BHoM/Excel_Toolkit/pull/280#issuecomment-780712374 potential to improve discoverability of method by pinning to UI toolbar as dedicated component.
This will naturally be partially addressed by inclusion of component ready placed on canvas in any templates.
Not for this PR - perhaps worth raising an issue if others agree
adecler
deleted the
BHoMAnalytics_Toolkit-#15-SaveFileNameAndProjectCode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#2312
BHoM/BHoM_UI#370
Issues addressed by this PR
Provide changes required for fileName and project code to be saved by analytics.
Test files
Will be tested alongside the BHoMAnalytics PR