Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection_Engine: Make the RecordEvent(Event) method public #2312

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 16, 2021

NOTE: Provides support to

BHoM/Grasshopper_UI#604
BHoM/BHoM_UI#370

Issues addressed by this PR

Provide changes required for fileName and project code to be saved by analytics. Two things were required here:

  • RecordEvent(Event) needed to be public to save other types of events (ses code in the BHoM_UI PR for where it is needed)
  • Fix a by where the private list of events was passed by the CurrentEvents method instead of a copy (see code in the Grashopper PR for where it is needed).

Test files

Will be tested alongside the BHoMAnalytics PR

@adecler
Copy link
Member Author

adecler commented Feb 17, 2021

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@adecler
Copy link
Member Author

adecler commented Feb 17, 2021

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2021

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 18, 2021

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@adecler adecler merged commit 24a4e08 into master Feb 19, 2021
@adecler adecler deleted the BHoMAnalytics_Toolkit-#15-SaveFileNameAndProjectCode branch February 19, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant