-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Error on pull caused by version update of ClosedXML to 0.102 #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested with the provided testfile which tests through a multitude of testcases for the adapter. All good there now.
Have not run any additional tests, but the test-file seemed to be covering the bases I could think of.
Code changes are all relatively small and I have a hard time seeing how they could accidentally break anything else.
Happy to approve and for this to be merged to be included in the beta, even this close to release.
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
Issues addressed by this PR
Fixes #71
Fixes #75
Fixes #69
Fixes #77
See issue for description.
We will need to further investigate the other changes brought by version 0.102 to make sure nothing else is broken.
Test files
Excel_Toolkit_Test01.zip
Additional comments
A few additional issues found and raised while working on this PR: