Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Error on pull caused by version update of ClosedXML to 0.102 #73

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Jun 3, 2024

Issues addressed by this PR

Fixes #71
Fixes #75
Fixes #69
Fixes #77

See issue for description.
We will need to further investigate the other changes brought by version 0.102 to make sure nothing else is broken.

Test files

Excel_Toolkit_Test01.zip

Additional comments

A few additional issues found and raised while working on this PR:

@adecler adecler added the type:bug Error or unexpected behaviour label Jun 3, 2024
@adecler adecler requested a review from FraserGreenroyd June 3, 2024 14:12
@adecler adecler self-assigned this Jun 3, 2024
@adecler adecler added the status:WIP PR in progress and still in draft, not ready for formal review label Jun 3, 2024
@adecler adecler requested review from IsakNaslundBh and removed request for FraserGreenroyd June 17, 2024 09:40
@adecler adecler removed the status:WIP PR in progress and still in draft, not ready for formal review label Jun 17, 2024
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested with the provided testfile which tests through a multitude of testcases for the adapter. All good there now.
Have not run any additional tests, but the test-file seemed to be covering the bases I could think of.

Code changes are all relatively small and I have a hard time seeing how they could accidentally break anything else.

Happy to approve and for this to be merged to be included in the beta, even this close to release.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 18, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Jun 18, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jun 18, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jun 18, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 18, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 20 requests in the queue ahead of you.

@adecler adecler merged commit 1c0120a into develop Jun 18, 2024
12 checks passed
@adecler adecler deleted the Excel_Toolkit-#71-FixingPull branch June 18, 2024 08:11
@adecler adecler mentioned this pull request Jun 19, 2024
@IsakNaslundBh IsakNaslundBh mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
2 participants