Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull fails when Excel file contains formulas #69

Closed
bjoernsteinhagen opened this issue Apr 24, 2024 · 1 comment · Fixed by #73
Closed

Pull fails when Excel file contains formulas #69

bjoernsteinhagen opened this issue Apr 24, 2024 · 1 comment · Fixed by #73
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@bjoernsteinhagen
Copy link

Description:

  • I read in an Excel file, which previously worked fine. The file has very simple formulas.
  • With the latest version of BHoM (7.2.0.240424), the pull fails.
  • I copied all text within the Excel file and pasted the data again just as values (removing formulas) and the pull then worked.

Steps to reproduce:

  • Create an Excel file where some rows use formulas
  • Try and read in the file in GH using BHoM pull (and Excel adapter)

Expected behaviour:

  • The adapter reads in the values which are as a result of the functions, not producing an error.
@bjoernsteinhagen bjoernsteinhagen added the type:bug Error or unexpected behaviour label Apr 24, 2024
@HugoVanLooveren
Copy link

I guess related to this issue is the fact that importing Excel content results in Goo types for numbers.
image

In BHoM version 7.0.1.1 it works:
image

To reproduce you need an Excel with a column filled with numbers. You can also use the one attached:
Book2.xlsx
(Could not attach a .gh file, so that should be made by yourself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants