Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.2 Deployment #32

Merged
merged 26 commits into from
Jun 21, 2023
Merged

6.2 Deployment #32

merged 26 commits into from
Jun 21, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Jun 12, 2023

BHoMBot and others added 26 commits June 12, 2023 22:58
@BHoMBot
Upgrade AssemblyFileVersion to 6.2.0.0
1f18005
@IsakNaslundBh
Fix issue with reading from synced file in a sharepoint folder
a9ea092
Upgrade to NetStandard2.0 for ZeroCodeTool deployments
4349929
Add compilation support between Net472 and NetStandard2.0
9ebab51
Update nugets accordingly for NS2.0 and NF472
06f8540
Remove unnecessary UI reference
cc2cb63
@BHoMBot
Update project compliance
b906f5f
Update postbuild following discussion with @adecler
8a9fd63
Update csproj
eedb265
@IsakNaslundBh
Add method for getting out value or cached value and use it for when …
070b0f4 
…accessing value of cLCell
@IsakNaslundBh
Add descriptions
bea3089
@IsakNaslundBh
Apply suggestions from code review
7816c33 
Co-authored-by: Fraser Greenroyd <[email protected]>
Add WorksheetsRequest object #27
5201f66
Add Worksheet object to return from pull #27
f8738b1
Add read/pull commands to the Adapter for pulling worksheet names #27
f7172d6
Add ability to filter worksheet names
159e041
Remove unnecessary using
930094f
Tidy up object file
88e8b04
@desaiwangBH
Updated Cell Range to Accept Numerical Only and Letter Only Inputs
9d67b08 
Now accepts only letters and only numbers, for example A:A, 2:3.

Also updated regular expressions to be case insensitive.
Update Excel_Engine/Query/IsValid.cs
89310b8
Update Excel_Engine/Query/IsValid.cs
6421ca4
Update to row or column selection filtering.
0748500
Tidy up usings
3ea0fe9
Give credit where credit is due
66d4b6e
@desaiwangBH
Created ExcelToolkitWiki.cs
36c67eb 
returns the wiki documentation link
Update Excel_Engine/Query/ExcelToolkitWiki.cs
b6c9fa6
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jun 12, 2023
@FraserGreenroyd FraserGreenroyd self-requested a review June 12, 2023 22:22
@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 270 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check branch-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check branch-compliance

There are 69 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check branch-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check branch-compliance

There are 68 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 58 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check installer

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 129 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 263 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Jun 21, 2023
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against beta test artefacts during final sprint and approved by DevOps.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Jun 21, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

FraserGreenroyd
FraserGreenroyd approved these changes Jun 21, 2023
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks completed. DevOps clear to deploy 6.2

@FraserGreenroyd FraserGreenroyd merged commit 422a903 into main Jun 21, 2023
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines and removed type:feature New capability or enhancement labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran

@Chrisshort92 Chrisshort92 Awaiting requested review from Chrisshort92

@jamesramsden-bh jamesramsden-bh Awaiting requested review from jamesramsden-bh

Assignees

@bhombot-ci bhombot-ci[bot]

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FraserGreenroyd @BHoMBot @IsakNaslundBh @desaiwangBH