-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to NetStandard 2.0 #24
Upgrade to NetStandard 2.0 #24
Conversation
@BHoMBot check project-complianced |
@FraserGreenroyd sorry, I didn't understand. |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 12972870256 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
…ub.com/BHoM/Excel_Toolkit into Excel_Toolkit-#17-UpgradeNetStandard20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot really contribute much about the change in VerifySecurityEvidenceForIsolatedStorage
as I was not really involved into that.
But, otherwise, the code changes make sense and all is working well when going through the steps described in the original message.
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Fixes #17 - second attempt.
I opted to take the same approach as for the SQL Toolkit PR to handle the lack of compatibility needed with Grasshopper highlighted in the first attempt in #18.
Test files
Excel_Adapter.dll
,Excel_Engine.dll
, andExcel_oM.dll
from your local assembliesdebug
mode - this should give you the same DLLs as the installerZeroCodeTool
mode - this should give you a new output folder in theExcel_Toolkit/Build
location.Net6
project, referencing the DLLs and try to pull some data replicating a script used in step 4. Providing the code compiles without compiler warnings (compiler warnings should relate to trying to use.NetFramework
in.Net
environments - these should NOT appear with this work) and data can be pulled into a console, this should be sufficient?Excel_Toolkit_Test.zip
But same as SQL_Toolkit, I'm a bit kind - this zip file should help with testing steps 6 onwards - it contains a
.Net6
solution with references to the right DLLs/nugets that would come if theNetStandard
adapter was included via a nuget (the ultimate end result for this work). You will need to reference theExcel_Adapter
,Excel_Engine
, andExcel_oM
from your local build ofExcel_Toolkit/Build/netstandard2.0
folder - but the other DLLs are already hardcoded forC:/ProgramData/BHoM
so hopefully minimal set up needed! You will need to update line 11 to your directory if you do use this. You can also set it up to pull data from other sheets in addition to the test one I've included.Also feel free to not use this - but it's what I made to help debug/run through my own testing instructions so figured I might as well share it! 😄
Additional comments
Other work to be included for audit as to how this approach ended up being picked:
PR #18