Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NetStandard 2.0 #24

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd commented Apr 24, 2023

Issues addressed by this PR

Fixes #17 - second attempt.

I opted to take the same approach as for the SQL Toolkit PR to handle the lack of compatibility needed with Grasshopper highlighted in the first attempt in #18.

Test files

  1. Install a recent alpha or the 6.1 beta (either works).
  2. Delete Excel_Adapter.dll, Excel_Engine.dll, and Excel_oM.dll from your local assemblies
  3. Compile in debug mode - this should give you the same DLLs as the installer
  4. Run test scripts of your choosing - these should run successfully without errors
  5. Compile in ZeroCodeTool mode - this should give you a new output folder in the Excel_Toolkit/Build location
  6. Hmm - how to test this bit?!?
  7. I'd recommend making a new .Net6 project, referencing the DLLs and try to pull some data replicating a script used in step 4. Providing the code compiles without compiler warnings (compiler warnings should relate to trying to use .NetFramework in .Net environments - these should NOT appear with this work) and data can be pulled into a console, this should be sufficient?

Excel_Toolkit_Test.zip

But same as SQL_Toolkit, I'm a bit kind - this zip file should help with testing steps 6 onwards - it contains a .Net6 solution with references to the right DLLs/nugets that would come if the NetStandard adapter was included via a nuget (the ultimate end result for this work). You will need to reference the Excel_Adapter, Excel_Engine, and Excel_oM from your local build of Excel_Toolkit/Build/netstandard2.0 folder - but the other DLLs are already hardcoded for C:/ProgramData/BHoM so hopefully minimal set up needed! You will need to update line 11 to your directory if you do use this. You can also set it up to pull data from other sheets in addition to the test one I've included.

Also feel free to not use this - but it's what I made to help debug/run through my own testing instructions so figured I might as well share it! 😄

Additional comments

Other work to be included for audit as to how this approach ended up being picked:
PR #18

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 24, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 24, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check project-complianced

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@FraserGreenroyd
Copy link
Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 24 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 12972870256

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 12972870256

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check project-compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance
  • check core

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really contribute much about the change in VerifySecurityEvidenceForIsolatedStorage as I was not really involved into that.
But, otherwise, the code changes make sense and all is working well when going through the steps described in the original message.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 26 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 89fa156 into develop Apr 25, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#17-UpgradeNetStandard20 branch April 25, 2023 16:52
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to .NetStandard 2.0
3 participants