Add support for future ETABS versions #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renaming ETABS18Adapter to simply ETABSAdapter to be used with any future version of ETABS - Adjusting default build to target ETABSAdapter, and using ETABSv1 api reference
…pter is starting the latest version of Etabs
|
@BHoMBot check core |
|
@IsakNaslundBh to confirm, the following checks are now queued:
There are 10 requests in the queue ahead of you. |
|
@BHoMBot check compliance |
|
@IsakNaslundBh to confirm, the following checks are now queued:
|
JosefTaylor
approved these changes
Jan 19, 2022
|
@IsakNaslundBh to confirm, the following checks are now queued:
|
|
@BHoMBot check installer |
|
@IsakNaslundBh to confirm, the following checks are now queued:
|
|
@IsakNaslundBh just to let you know, I have provided a |
IsakNaslundBh
deleted the
ETABS_Toolkit-#391-AddSupportForFutureEtabsVersions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #391
WIth the API changed for Etabs from version 18 and onwards, the API is stated to work for future versions of the software. Hence, refactoring the adapter to reflect this. The ETABS18ADapter is renamed ETABSAdapter, as it should work for 18, 19 and future versions, with no requirements for special builds.
Keeping the 2016 and 17 adapters as is for backwards compatibility with those versions of the software.
The initialisation code for starting ETABS has been changed for the new ETABSAdapter to start the latest version of ETABS installed on the system, rather than pointing at a particular source folder. This means this part of the code does not need to be updated for every release of the software, and mimics what has been done for SAP2000.
Also cleaned up a significant amount of unrequired usings of the api reference to simplify the code.
Test files
Specific testfile to test versioning in here. To test the versioning, make sure you manually delete the Etabs18_adapter.dll file from the assemblies folder in ProgramData. On this PR the EtabsAdapter will be marked as prototype, but that will not be the case as soon as the dlls have been updated in the installer.:
https://burohappold.sharepoint.com/:f:/s/BHoM/EjQQjb2k76pDs0Nkecwaq4IBOHDMKP_yNS4dcZnx3nYpVA?e=ubLiiO
The ETABSAdapter should work as the previous ETABS18ADapter did. Regular test scripts or project scripts good to use as a test-case.
Changelog
Additional comments