Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with changes to ETABS adapter to support version of ETABS after 18 #145

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/ETABS_Toolkit#399

Issues addressed by this PR

Updating buildconfigs to reflect changes in ETABS toolkit

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 18, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 18, 2022
@IsakNaslundBh IsakNaslundBh changed the title Update altConfigs.txt ALign with changes to ETABS adapter to support version of ETABS after 18 Jan 18, 2022
@IsakNaslundBh IsakNaslundBh changed the title ALign with changes to ETABS adapter to support version of ETABS after 18 Align with changes to ETABS adapter to support version of ETABS after 18 Jan 18, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 20, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance

There are 8 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 20, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer is building fine, this is good to go following the review on Etabs that brings in the change of functionality.

@FraserGreenroyd FraserGreenroyd merged commit c87e809 into main Jan 20, 2022
@FraserGreenroyd FraserGreenroyd deleted the ETABS_Toolkit-#391-AddSupportForFutureEtabsVersions branch January 20, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants