Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper protection for IsEquals check for Serialisation #3443

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #3442

Add try-catch around IsEquals method to ensure it does not crash the whole test method, if exception is raised inside.

Test files

running check serialisaiton should show some known errors for objects

Changelog

Additional comments

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Dec 11, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check serialisation

There are 1 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 11, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Dec 11, 2024

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Dec 11, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

There are 11 requests in the queue ahead of you.

@adecler
Copy link
Member

adecler commented Dec 12, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 12, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed and reviewed during a call with Isak and Pawel. Happy to approve from that.

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

There are 3 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Dec 12, 2024

FAO: @adecler @pawelbaran @IsakNaslundBh
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is serialisation.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 34308208495

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 34308208495

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I have now provided a passing check on reference 34308208495 as requested.

@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Dec 12, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh self-assigned this Dec 12, 2024
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Dec 12, 2024
Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 6feaefa into develop Dec 12, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Engine-#3442-AddProtectionForIsEqualsCheck branch December 12, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with Serialisation check for objects requiring more protection
2 participants