-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper protection for IsEquals check for Serialisation #3443
Add proper protection for IsEquals check for Serialisation #3443
Conversation
@BHoMBot check serialisation |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check required |
@adecler to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed and reviewed during a call with Isak and Pawel. Happy to approve from that.
@IsakNaslundBh to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
FAO: @adecler @pawelbaran @IsakNaslundBh The check they wish to have dispensation on is serialisation. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 34308208495 |
@IsakNaslundBh I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3442
Add try-catch around IsEquals method to ensure it does not crash the whole test method, if exception is raised inside.
Test files
running check serialisaiton should show some known errors for objects
Changelog
Additional comments