Add proper protection for IsEquals check for Serialisation (#3443)

BHoM · Dec 12, 2024 · 6feaefa · 6feaefa
2 parents 4eac991 + b64eafa
commit 6feaefa
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.ci/code/Serialiser_Test/Verify/ObjectsToFromJson.cs b/.ci/code/Serialiser_Test/Verify/ObjectsToFromJson.cs
@@ -132,7 +132,19 @@ public static TestResult ObjectToFromJson(Type type)
                     Engine.Base.Compute.RecordError(e.Message);
                 }
 
-                if (!testObject.IsEqual(copy))
+                bool isEqual;
+
+                try
+                {
+                    isEqual = testObject.IsEqual(copy);
+                }
+                catch (Exception e)
+                {
+                    BH.Engine.Base.Compute.RecordError(e, $"Failed to compare the objcets of type {type.Name}");
+                    isEqual = false;
+                }
+
+                if (!isEqual)
                     return new TestResult
                     {
                         Description = typeDescription,

diff --git a/Diffing_Engine/Diffing_Engine.csproj b/Diffing_Engine/Diffing_Engine.csproj
@@ -17,7 +17,7 @@
     <Exec Command="xcopy &quot;$(TargetDir)$(TargetFileName)&quot;  &quot;C:\ProgramData\BHoM\Assemblies&quot; /Y&#xD;&#xA;&#xD;&#xA;xcopy &quot;$(TargetDir)KellermanSoftware.Compare-NET-Objects.dll&quot;  &quot;C:\ProgramData\BHoM\Assemblies&quot; /Y" />
   </Target>
   <ItemGroup>
-    <PackageReference Include="CompareNETObjects" Version="4.67.0" />
+    <PackageReference Include="CompareNETObjects" Version="4.83.0" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\BHoM_Engine\BHoM_Engine.csproj" />