-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data_Engine: Fix typo in DomainTree creation #3321
Data_Engine: Fix typo in DomainTree creation #3321
Conversation
@BHoMBot check required |
@vietle-bh to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on code review and historical review here which shows that using min - max
was put in to other areas which does suggest this is a typo bug.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@vietle-bh just a gentle reminder to include which engine is primarily affected by a PR to the BHoM_Engine repository in the title - I've added |
Issues addressed by this PR
Closes #3317
The existing code does (min + min)/2 which I've rectified to (min + max)/2.
Test files
It's just a typo so hopefully someone who worked on Domain Tree before can approve right away 😉
Changelog
Additional comments