Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data_Engine: Fix typo in DomainTree creation #3321

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

vietle-bh
Copy link
Contributor

Issues addressed by this PR

Closes #3317

The existing code does (min + min)/2 which I've rectified to (min + max)/2.

Test files

It's just a typo so hopefully someone who worked on Domain Tree before can approve right away 😉

Changelog

Additional comments

@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Mar 12, 2024
@vietle-bh vietle-bh self-assigned this Mar 12, 2024
@vietle-bh
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 12, 2024

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 20 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on code review and historical review here which shows that using min - max was put in to other areas which does suggest this is a typo bug.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit aed0d06 into develop Mar 13, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Data_Engine-#3317-FixTypoInDomainTree branch March 13, 2024 12:05
@FraserGreenroyd FraserGreenroyd changed the title Fix typo in DomainTree creation Data_Engine: Fix typo in DomainTree creation Mar 13, 2024
@FraserGreenroyd
Copy link
Contributor

@vietle-bh just a gentle reminder to include which engine is primarily affected by a PR to the BHoM_Engine repository in the title - I've added Data_Engine for this one 😄 just helps our automated change log processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
Development

Successfully merging this pull request may close these issues.

Typo in DomainTree creation
2 participants