Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in DomainTree creation #3317

Closed
vietle-bh opened this issue Mar 12, 2024 · 0 comments · Fixed by #3321
Closed

Typo in DomainTree creation #3317

vietle-bh opened this issue Mar 12, 2024 · 0 comments · Fixed by #3321
Assignees
@vietle-bh
Labels
type:bug Error or unexpected behaviour

Comments

@vietle-bh
Copy link
Contributor

vietle-bh commented Mar 12, 2024 •
edited
Loading

Description:

There seems to be a typo here ((min + min)/2):

BHoM_Engine/Data_Engine/Create/DomainTree.cs

Line 130 in d13f40b

if ((data.DomainBox.Domains[index].Min + data.DomainBox.Domains[index].Min) / 2 < centre)

Steps to reproduce:

Expected behaviour:

The line should read ((min + max)/2)
if ((data.DomainBox.Domains[index].Min + data.DomainBox.Domains[index].Max) / 2 < centre)

Test file(s):
@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Mar 12, 2024
@vietle-bh vietle-bh self-assigned this Mar 12, 2024
@vietle-bh vietle-bh mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vietle-bh vietle-bh

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data_Engine: Fix typo in DomainTree creation BHoM/BHoM_Engine
1 participant
@vietle-bh