-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine - Adding tolerance to create panel methods #3005
Structure_Engine - Adding tolerance to create panel methods #3005
Conversation
Adding tolerance to Create panel methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the code and tested the provided script successfully with the new additional tolerance input.
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 38 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense, versioning is happy, happy to deploy following hack session.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #2961
Adding tolerance the the Create.Panel methods in the Structural engine. At least for the ones where that makes sense. The other ones don't require any checks that involve the tolerance.
Test files
CreatePlanarCurveWithTolerance.zip
Changelog
Additional comments