Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine - Adding tolerance to create panel methods #3005

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 9, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #2961

Adding tolerance the the Create.Panel methods in the Structural engine. At least for the ones where that makes sense. The other ones don't require any checks that involve the tolerance.

Test files

CreatePlanarCurveWithTolerance.zip

Changelog

Additional comments

@adecler adecler added the type:feature New capability or enhancement label Feb 9, 2023
@adecler adecler requested a review from michaelhoehn February 9, 2023 17:03
@adecler adecler self-assigned this Feb 9, 2023
michaelhoehn
michaelhoehn previously approved these changes Feb 9, 2023
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code and tested the provided script successfully with the new additional tolerance input.

Structure_Engine/Create/Elements/Panel.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/Panel.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/Panel.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 38 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, versioning is happy, happy to deploy following hack session.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 4f43383 into develop Feb 10, 2023
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#2961-AddingToleranceToCreatePanelMethods branch February 10, 2023 15:49
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Create.Panel methods do not take tolerance input
3 participants