Reflection_Engine: Final tidy up

[FraserGreenroyd]

Issues addressed by this PR

Fixes #2734

Test files

Changelog

Additional comments

Everything that remains/wasn't moved I consider to be a part of 'reflection' - the act of the code asking questions about itself in some fashion or another.

I added documentation for any file I touched that didn't have any.

I also added some unit tests because, why not? 😄

For the URL unit test, I obtained all of the types from the BHoM repo, then checked all of their URLs to see which ones returned a 404 - indicating the URL generated is not valid for that type. I then removed those and produced the unit test on the working ones. The reason for this is that we then have a store of the working outputs that we don't want to change - and any subsequent PRs which fix or resolve the non-working URL generations will want to check the working ones haven't broken too. Hopefully that makes sense 😄

[FraserGreenroyd]

@BHoMBot check installer

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check installer

There are 7 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 18 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 8 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check null-handling
• check serialisation
• check unit-tests

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

There are 16 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 9 requests in the queue ahead of you.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance

There are 3 requests in the queue ahead of you.

[IsakNaslundBh]

Changes look good.

See comments on potential further simplification and removal of some methods that I cannot really see any point in keeping :)

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check unit-tests
• check versioning

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check core

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check null-handling
• check serialisation
• check core

[IsakNaslundBh]

Codechanges looks good and make sense.

Made a quick test of calling the Count method from exce, including checking the versioning functioning, and no issues to report.

Approved

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge