Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection_Engine: Further review #2734

Closed
FraserGreenroyd opened this issue Jan 14, 2022 · 0 comments · Fixed by #2944
Closed

Reflection_Engine: Further review #2734

FraserGreenroyd opened this issue Jan 14, 2022 · 0 comments · Fixed by #2944
Assignees
@FraserGreenroyd
Labels
type:compliance Non-conforming to code guidelines
Milestone
BHoM 5.1 β MVP

Comments

@FraserGreenroyd
Copy link
Contributor

Following merging of #2729 not all methods in Reflection_Engine need to continue residing there. That PR broke the core dependency between the BHoM_Engine and Reflection_Engine.

Further review is now needed to look at moving other methods, such as IsPrototype, etc.

FYI: @adecler @IsakNaslundBh @al-fisher @alelom @pawelbaran
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 14, 2022
@FraserGreenroyd FraserGreenroyd added this to the BHoM 5.1 β MVP milestone Jan 14, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 14, 2022
@FraserGreenroyd FraserGreenroyd mentioned this issue Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 5.1 β MVP
Development

Successfully merging a pull request may close this issue.

Reflection_Engine: Final tidy up BHoM/BHoM_Engine
1 participant
@FraserGreenroyd