Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge #2865

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge #2865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf48469
Return empty MatComp for valid empty frameEdge
enarhi Jun 15, 2022
2687d29
Updated returned MatComp to be truly empty
enarhi Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Facade_Engine/Query/MaterialComposition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ public static MaterialComposition MaterialComposition(this FrameEdge frameEdge)

if (frameEdge.FrameEdgeProperty == null || frameEdge.FrameEdgeProperty.SectionProperties.Count() == 0)
{
Engine.Base.Compute.RecordWarning("FrameEdge " + frameEdge.BHoM_Guid + " does not have a frame edge property assigned to get material composition from.");
return null;
Engine.Base.Compute.RecordWarning("FrameEdge " + frameEdge.BHoM_Guid + " does not have a frame edge property assigned to get material composition from, so the material composition returned is empty.");
return new MaterialComposition(new List<Material>(), new List<double>()); ;
}

if (frameEdge.FrameEdgeProperty.SectionProperties.Any(x => x.Material == null))
Expand Down