-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge #2865
Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge #2865
Conversation
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
|
@BHoMBot check required |
@enarhi to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check compliance |
@enarhi to confirm, the following checks are now queued:
There are 12 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@BHoMBot check null-handling |
@enarhi to confirm, the following checks are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check required |
@enarhi to confirm, the following checks are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following checks are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #2864
Made MaterialComposition return an empty MaterialComposition for a valid empty frame edge.
Test files
Facade_Engine Test File