Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge #2865

Merged

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Jun 16, 2022

NOTE: Depends on

Issues addressed by this PR

Closes #2864

Made MaterialComposition return an empty MaterialComposition for a valid empty frame edge.

Test files

Facade_Engine Test File

@enarhi enarhi requested a review from vgreen-BH June 16, 2022 00:00
@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 4 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@enarhi enarhi changed the title Facade_Engine: MaterialComposition tweak to return valide empty value for valid empty frame edge Facade_Engine: MaterialComposition tweak to return valid empty value for valid empty frame edge Jun 16, 2022
@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • null-handling

There are 11 requests in the queue ahead of you.

@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

@enarhi enarhi self-assigned this Jun 16, 2022
@enarhi enarhi added the type:bug Error or unexpected behaviour label Jun 16, 2022
@enarhi
Copy link
Member Author

enarhi commented Jun 16, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2022

@enarhi to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 8c8f437 into main Jun 16, 2022
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#2864-MaterialCompositionNullTweak branch June 16, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Ensure MaterialComposition returns valid object for any valid input
3 participants