Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Update to area loads visualisation #1966

Merged
merged 5 commits into from
Sep 8, 2020
Merged

Structure_Engine: Update to area loads visualisation #1966

merged 5 commits into from
Sep 8, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Sep 7, 2020 •
edited
Loading

Issues addressed by this PR

Closes #1965

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Em_LdUZqgX1KuIVqdNMiGJcBlPpuLhdHOREUu3lv_eSfTQ?e=ARRPJB

Test files with updated visualisations:

https://burohappold.sharepoint.com/:f:/s/BHoM/EhgghoopPXpHispXwTlB240BQpShlJn1oWapcJUVkzDSUA?e=uSOKbG

Changelog

  • Area load visualisation to make use of LocalOrientation for displaying local loads
  • Add support for displaying Arealoads on FEMeshes
  • Add support for visualisation of ContourLoad and GeometricLineLoad

Additional comments

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review September 7, 2020 11:14
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 7, 2020
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Sep 7, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.3 β MVP milestone Sep 7, 2020
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Sep 7, 2020
pawelbaran
pawelbaran approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could only complain about the distribution of the blank lines 🤣

pawelbaran
pawelbaran requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although descriptions require another look.

Structure_Engine/Query/PointGrid.cs Show resolved Hide resolved
Structure_Engine/Query/PointGrid.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/Visualize.cs Outdated Show resolved Hide resolved
Structure_Engine/Query/Visualize.cs Outdated Show resolved Hide resolved
@IsakNaslundBh
Copy link
Contributor Author

Thanks @pawelbaran . Think I have addressed your points (also deleted some blank lines :) )

pawelbaran
pawelbaran approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@IsakNaslundBh
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 9275ddc into master Sep 8, 2020
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-#1965-UpdateToAreaLoadsVisualisation branch September 8, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@peterjamesnugent peterjamesnugent Awaiting requested review from peterjamesnugent

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.3 β MVP
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Visualising loads in local axis needs update with local orientation
2 participants
@IsakNaslundBh @pawelbaran