Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
IsakNaslundBh committed Sep 8, 2020
1 parent e2e8e89 commit 9275ddc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
7 changes: 4 additions & 3 deletions Structure_Engine/Query/PointGrid.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,10 @@ public static List<List<Point>> PointGrid(this FEMesh mesh)
return mesh.Faces.Select(x => x.PointGrid(mesh)).ToList();
}

[Description("Generates a rectangular grid of points on the each face of the FEMesh. Used for load visualisation.")]
[Input("mesh", "The FEMesh to generate a grid on.")]
[Output("grid", "Rectangular grid of points on the FEMesh.")]
[Description("Generates a rectangular grid of points on the FEMeshFace of the FEMesh. Used for load visualisation.")]
[Input("face", "The FEMeshFace to generate a grid on.")]
[Input("mesh", "The FEMesh to which the face belongs.")]
[Output("grid", "Rectangular grid of points on the FEMeshFace.")]
public static List<Point> PointGrid(this FEMeshFace face, FEMesh mesh)
{
List<Point> pts = face.NodeListIndices.Select(i => mesh.Nodes[i].Position).ToList();
Expand Down
8 changes: 2 additions & 6 deletions Structure_Engine/Query/Visualize.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public static List<ICurve> Visualize(this AreaTemperatureLoad areaTempLoad, doub

foreach (IAreaElement element in areaTempLoad.Objects.Elements)
{

List<List<ICurve>> allEdges = edgeDisplay ? ISubElementBoundaries(element) : new List<List<ICurve>>();
List<Basis> allOrientations = IAllLocalOrientations(element);
List<List<Point>> subElementGrids = gridDisplay ? ISubElementPointGrids(element) : new List<List<Point>>();
Expand Down Expand Up @@ -106,7 +105,6 @@ public static List<ICurve> Visualize(this AreaUniformlyDistributedLoad areaUDL,

for (int i = 0; i < allOrientations.Count; i++)
{

IEnumerable<ICurve> edges = edgeDisplay ? allEdges[i] : null;
List<Point> pts = gridDisplay ? subElementGrids[i] : null;
Basis orientation = allOrientations[i];
Expand Down Expand Up @@ -481,7 +479,7 @@ public static List<ICurve> Visualize(this PointVelocity pointVelocity, double sc
/***************************************************/

[Description("Draws arrows representing the load along the edges of the contour of the load.")]
[Input("pointVelocity", "The node load to visualise.")]
[Input("contourLoad", "The ContourLoad to visualise.")]
[Input("scaleFactor", "Scales the arrows drawn. Default scaling of 1 means 1 m/s per metre.")]
[Input("displayForces", "Toggles whether forces should be displayed or not.")]
[Input("displayMoments", "Toggles whether moments should be displayed or not. Unused for contour loads.")]
Expand Down Expand Up @@ -520,14 +518,13 @@ public static List<ICurve> Visualize(this ContourLoad contourLoad, double scaleF

arrows.AddRange(ConnectedArrows(contourLoad.Contour.SubParts(), forceVec, asResultants, orientation, 1, true));


return arrows;
}

/***************************************************/

[Description("Draws arrows representing the load along the length of the line of the load.")]
[Input("pointVelocity", "The node load to visualise.")]
[Input("lineLoad", "The GeometricalLineLoad to visualise.")]
[Input("scaleFactor", "Scales the arrows drawn. Default scaling of 1 means 1 m/s per metre.")]
[Input("displayForces", "Toggles whether forces should be displayed or not.")]
[Input("displayMoments", "Toggles whether moments should be displayed or not. Unused for contour loads.")]
Expand Down Expand Up @@ -594,7 +591,6 @@ public static List<ICurve> Visualize(this GeometricalLineLoad lineLoad, double s

}


return arrows;
}

Expand Down

0 comments on commit 9275ddc

Please sign in to comment.