Common_Engine: Remove Deprecated Methods #1784
Conversation
kThorsager
added
the
status:WIP
kThorsager
added
type:compliance
kThorsager
requested review from
al-fisher,
FraserGreenroyd,
IsakNaslundBh,
pawelbaran and
rwemay
as code owners
kThorsager
changed the title
|
/azp run BHoM_Engine.CheckCompliance |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Had to upgrade from master locally for versioning to work (as the upgrade system change had been merged after this PR was created), but after doing so, all test files in Common_Engine upgraded like a charm and worked as expected. Happy to approve, but will hold off merging for a day or two to give someone else a chance to shout before I do. @alelom @FraserGreenroyd @al-fisher
|
compliance complains about wrong build folder for Common_Engine. Think we can live with that as it should not be used any longer and is about to get removed. |
Agreed |
There was a problem hiding this comment.
I was happy with what I saw so am happy to approve. Also happy to wait for more reviews as per @IsakNaslundBh comment before merging.
IsakNaslundBh
deleted the
Common_Engine-#1624-Remove-deprecated-methods-v2
branch
Issues addressed by this PR
recreating this from #1759 as update from master implied difficulties to merge there.
Closes #1624
Removes all methods in Common_Engine which were moved to Spatial_Engine and adds Versioning for them.
Test files
Common_Engines regular testfiles are here and are upgraded with this PR. i.e. the old labels are removed and they still work.
https://burohappold.sharepoint.com/:f:/s/BHoM/EvyCGXcAkK5OqmqvtfZkZMABtuDNXxKAG7YZdY-dI0SWXA?e=rXXt8h
Changelog
Additional comments