Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common_Engine: Remove ConstructionPhase Create method #1793

Closed
kThorsager opened this issue May 22, 2020 · 0 comments · Fixed by #1825
Closed

Common_Engine: Remove ConstructionPhase Create method #1793

kThorsager opened this issue May 22, 2020 · 0 comments · Fixed by #1825
Assignees
@kThorsager
Labels
type:compliance Non-conforming to code guidelines

Comments

@kThorsager
Copy link
Contributor

kThorsager commented May 22, 2020 •
edited
Loading

Broken rules:

Is just a property setter, and removing will alleviate migration of object in oM

Suggestions to restore compliance:

Remove method,
Will not preform versioning as slim use and don't remember versioning from Engine method -> oM constructor

possible after #1784

Main issue BHoM/BHoM#887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kThorsager kThorsager

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Common_Engine: Remove ConstructionPhase Create method BHoM/BHoM_Engine
1 participant
@kThorsager